Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate suggested changes for tree views and list views #79

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

  • In our last gsoc meeting on Aug 9, we discussed changing the views for ParticleId and Reco Tree.
  • In the case of ParticleId (and any view that is a list), there was the case that if not enough elements, when showing from left to right, it would be hard to visualize because are aligned to left. Instead, now it will be centered, so it's easier to view elements that are in the last row.
  • For the case of tree views, like RecoParticle Tree, there are a lot of elements that are not connected to anything, so they'll be in a large row. Instead, tree views are combined with list views, so those objects that aren't connected to anything, will show as a list, and later on, the tree.

ENDRELEASENOTES

Copy link

github-actions bot commented Aug 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-14 19:39 UTC

@kjvbrt
Copy link
Collaborator

kjvbrt commented Aug 12, 2024

Hi @brauliorivas,
I like the changes: :)

when trying particle ID list I get however halves of infoboxes on the right side:
image
Do you use width of the screen to determine number of elements in the row? Or this is just a coincidence?

@brauliorivas
Copy link
Member Author

when trying particle ID list I get however halves of infoboxes on the right side:

Oh, didn't see it coming. This new line would allow to add or not one last column, but making sure won't show the halve of the box.

Do you use width of the screen to determine number of elements in the row? Or this is just a coincidence?

Yes, I use the width of the screen.

@kjvbrt
Copy link
Collaborator

kjvbrt commented Aug 13, 2024

Now it look better, but there is still shift in the array by half of the width of the box to the left. Can you center the infoboxes horizontally? :)

@kjvbrt kjvbrt merged commit 9903888 into key4hep:main Aug 14, 2024
2 checks passed
@kjvbrt
Copy link
Collaborator

kjvbrt commented Aug 14, 2024

Hi @brauliorivas,this looks nice now. merging this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants