-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build RTL-SDR drivers from source #229
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really blockers IMO, just a couple things I noticed and wasn't entirely sure about
@@ -14,7 +14,7 @@ ENV DUMP1090_ADAPTIVE_MAX_GAIN="" | |||
ENV DUMP1090_SLOW_CPU="" | |||
ENV REBOOT_DEVICE_ON_SERVICE_EXIT="" | |||
|
|||
ARG PERM_INSTALL="tini lighttpd gettext-base libusb-1.0-0 libbladerf2 libhackrf0 liblimesuite22.09-1 librtlsdr0 rtl-sdr libsoapysdr0.8 libncurses6 libboost-system-dev libboost-program-options-dev libboost-regex-dev" | |||
ARG PERM_INSTALL="tini lighttpd gettext-base libusb-1.0-0 libbladerf2 libhackrf0 liblimesuite22.09-1 libsoapysdr0.8 libncurses6 libboost-system-dev libboost-program-options-dev libboost-regex-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has libsoapysdr0.8
here but then it's not installed in the same way as dump978 further down?
Not sure if it needs adding or whether the package is maybe not needed?
# renovate: datasource=github-tags depName=osmocom/rtl-sdr versioning=loose | ||
ARG RTLSDR_VERSION=v2.0.2 | ||
# renovate: datasource=github-tags depName=pothosware/SoapyRTLSDR versioning=loose | ||
ARG SOAPYRTLSDR_VERSION=soapy-rtl-sdr-0.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to do a custom capture group in the renovate.json so it ignores the "soapy-rtl-sdr" prefix when looking for an updated version.
I'll test it on my forked version of the repo in a bit. Probably not a blocker to merging though IMO.
This pull request builds the RTL-SDR library from the Osmocom source rather than using the Debian packages. This change is to support newer hardware, such as the RTL-SDR Blog v4, which is currently not supported by the prebuilt packages. I have tested the changes on the v4, and it works fine now.
For dump978, the SoapyRTLSDR module is built manually as well.
As there is no UAT traffic in my area, testing of this functionality would be appreciated.
I'm unsure if I got the renovate settings correct, @Teko012, so any input would be appreciated. 😊
Closes #227