fix: Share a single database sessions starting from __handle_formatted_events to RuleEngine #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
VladimirFilonov
force-pushed
the
fix/2052-rules-session-race-conditions
branch
from
38fb8b6 to
f5b5059
Compare
VladimirFilonov
force-pushed
the
fix/2052-rules-session-race-conditions
branch
from
f5b5059 to
b224156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2052
📑 Description
Problem: sometimes, we experience deadlocks during the
RuleEngine.run_rulesexecutionI assume that we are using multiple database sessions in various functions, which are called inside
run_rules.In this PR, I'm adding the possibility of passing an existing session to downstream functions to prevent such race conditions.
✅ Checks
ℹ Additional Information