Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test if all providers are documented #2034

Merged
merged 20 commits into from
Sep 30, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Sep 29, 2024

Noticed that ServiceNow provider is not documented or mentioned in our docs. This test will fail if one will add a provider without docs.

Closes #2035

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 6:18pm

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 29, 2024 18:04
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would separate the new docs thingy in to a different workflow that only triggers when providers/** directory changes. It makes sense not to run it every time and in general I’m paranoid about all these scripts :( (bad past experience 😅)

@Matvey-Kuk
Copy link
Contributor Author

@talboren good idea, moved!

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matvey-Kuk Matvey-Kuk merged commit ede3eaf into main Sep 30, 2024
11 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/all-providers-should-be-documented branch September 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: Test if all providers are documented
2 participants