-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add time frame #1965
feat: add time frame #1965
Conversation
@rajeshj11 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
@Matvey-Kuk @talboren please review |
Waiting if #1770 (comment) has a PR before reviewing |
#1770 (comment) |
@rajeshj11 please add a loom/screenshots to the description of the PR so we can see that context of the change |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@talboren please check the demo |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
- Coverage 69.40% 68.32% -1.09%
==========================================
Files 145 151 +6
Lines 11810 12681 +871
==========================================
+ Hits 8197 8664 +467
- Misses 3613 4017 +404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Matvey-Kuk @talboren Could you please review? I have added the demo video too. |
@Matvey-Kuk I just wanted to check in on this PR. When you have time, I'd appreciate your review and any feedback. Let me know if there's anything that needs clarification or further improvement. Thanks for your time! |
Signed-off-by: Rajesh Jonnalagadda <[email protected]>
@talboren I noticed that my pull request has been inactive for some time. If it's no longer needed or doesn’t meet the requirements, please feel free to close it—I completely understand. |
@rajeshj11 i see that you are waiting for feedback from @Matvey-Kuk, correct? |
Yes, if someone could provide an update on when I can expect feedback from @Matvey-Kuk, I would appreciate it. If I have a rough estimate of a few days, I won’t need to follow up multiple times. |
Closes #1770
/claim #1770
📑 Description
Add time frame
✅ Checks
ℹ Additional Information
demo video:
https://www.loom.com/share/f0f25de12e724e8c97b62d88f25067e5