fix: frontend warnings (#2902)

keephq · Dec 25, 2024 · c8506df · c8506df
1 parent 55cb0e5
commit c8506df
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 29 deletions.
diff --git a/keep-ui/features/incident-list/ui/incident-table-component.tsx b/keep-ui/features/incident-list/ui/incident-table-component.tsx
@@ -100,29 +100,28 @@ export const IncidentTableComponent = (props: Props) => {
       </TableHead>
       <TableBody>
         {table.getRowModel().rows.map((row) => (
-          <>
-            <TableRow
-              key={row.id}
-              className="even:bg-tremor-background-muted even:dark:bg-dark-tremor-background-muted"
-            >
-              {row.getVisibleCells().map((cell) => {
-                const { style, className } =
-                  getCommonPinningStylesAndClassNames(cell.column);
-                return (
-                  <TableCell
-                    key={cell.id}
-                    style={style}
-                    className={clsx(
-                      className,
-                      cell.column.id === "actions" ? "p-1" : ""
-                    )}
-                  >
-                    {flexRender(cell.column.columnDef.cell, cell.getContext())}
-                  </TableCell>
-                );
-              })}
-            </TableRow>
-          </>
+          <TableRow
+            key={row.id}
+            className="even:bg-tremor-background-muted even:dark:bg-dark-tremor-background-muted"
+          >
+            {row.getVisibleCells().map((cell) => {
+              const { style, className } = getCommonPinningStylesAndClassNames(
+                cell.column
+              );
+              return (
+                <TableCell
+                  key={cell.id}
+                  style={style}
+                  className={clsx(
+                    className,
+                    cell.column.id === "actions" ? "p-1" : ""
+                  )}
+                >
+                  {flexRender(cell.column.columnDef.cell, cell.getContext())}
+                </TableCell>
+              );
+            })}
+          </TableRow>
         ))}
       </TableBody>
     </Table>

diff --git a/keep-ui/features/incident-list/ui/incidents-table.tsx b/keep-ui/features/incident-list/ui/incidents-table.tsx
@@ -285,7 +285,6 @@ export default function IncidentsTable({
     enableSorting: true,
     enableMultiSort: false,
     manualSorting: true,
-    debugTable: true,
   });
 
   const selectedRowIds = Object.entries(
@@ -315,11 +314,11 @@ export default function IncidentsTable({
       return;
     }
 
-    if (
-      !confirm(
-        `Are you sure you want to delete ${selectedRowIds.length} incidents? This action cannot be undone.`
-      )
-    ) {
+    const isConfirmed = confirm(
+      `Are you sure you want to delete ${selectedRowIds.length} incidents? This action cannot be undone.`
+    );
+
+    if (!isConfirmed) {
       return;
     }
 

diff --git a/keep-ui/next.config.js b/keep-ui/next.config.js
@@ -24,6 +24,19 @@ const nextConfig = {
       );
     }
 
+    // Ignore warnings about critical dependencies, since they are not critical
+    // https://github.com/getsentry/sentry-javascript/issues/12077#issuecomment-2407569917
+    config.ignoreWarnings = [
+      ...(config.ignoreWarnings || []),
+      {
+        module: /@opentelemetry\/instrumentation/,
+        message: /Critical dependency/,
+      },
+      {
+        module: /@prisma\/instrumentation/,
+        message: /Critical dependency/,
+      },
+    ];
     return config;
   },
   transpilePackages: ["next-auth"],