Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement group sync #9778

Closed
wants to merge 2 commits into from
Closed

Conversation

evur
Copy link

@evur evur commented Aug 22, 2023

Some small modifications to sync groups.

This is a really important feature, which is long overdue and the expected behavior for many users.

Fixes #3045

ToDo

  • Add a setting to disable the feature
  • Add unit tests
  • Sync root group icon if possible (maybe this needs to be fixed in the merge function idk)

NOTE: I personally won't implement these todos, as I'm not experienced with the codebase and Qt. Feel free to implement them and add them to the PR.

Testing strategy

Create a KeeShare between two databases, add groups and entries to it and set icons and custom icons.

Type of change

  • ✅ New feature (change that adds functionality)

@michaelk83
Copy link

AFAIK KeeShare is being reworked for 2.8.0, so you may want to wait with further work on this.

@evur
Copy link
Author

evur commented Aug 23, 2023

AFAIK KeeShare is being reworked for 2.8.0, so you may want to wait with further work on this.

I just created this PR so it's possible for maintainers to continue working on it and for others to easily get this functionality. This means that I won't work on this PR as I don't have experience with KeePassXC's codebase and don't know what exactly is getting reworked.

@droidmonkey
Copy link
Member

I might merge this work with what I already have done for KeeShare refactor. Thank you for the contribution!

@droidmonkey droidmonkey added this to the v2.8.0 milestone Jan 6, 2024
@BenKluwe
Copy link

I'd love to add to this but I can't figure out how to do it. In the code I've added a setting on the group's keeshare settings page for recursion but since I'm operating on a fork and the pr is from a different repo github isn't allowing me to add my commit -- and rightly so --

@evur
Copy link
Author

evur commented Jul 21, 2024

@BenKluwe I've just added your changes to the branch and invited you as contributor

@droidmonkey droidmonkey modified the milestones: v2.8.0, v2.7.10 Aug 19, 2024
@droidmonkey
Copy link
Member

@evur can you open this PR for maintainers to contribute to? Otherwise I will have to close this and re-open on our end.

@evur evur marked this pull request as ready for review December 24, 2024 10:32
@evur
Copy link
Author

evur commented Dec 24, 2024

Hi @droidmonkey, I've converted this into an open PR. I don't know if this helps and haven't found any option to allow edits by maintainers. If you still can't commit, feel free to close this and open a new PR.

@droidmonkey
Copy link
Member

I think because you opened this PR under your organization's fork there must be a permission issue on the organization preventing write back. Will just move this to another PR, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to sync group structure with KeeShare
4 participants