some fixes

kashif · Oct 23, 2023 · 1c9feec · 1c9feec
1 parent 37c3455
commit 1c9feec
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/gluonts/core/serde/_dataclass.py b/src/gluonts/core/serde/_dataclass.py
@@ -115,7 +115,7 @@ def _call(self, env):
 def dataclass(
     cls=None,
     *,
-    init=True,
+    init=False,
     repr=True,
     eq=True,
     order=False,
@@ -131,7 +131,7 @@ def dataclass(
     """
 
     # assert frozen
-    assert init
+    assert init is False
 
     if cls is None:
         return _dataclass

diff --git a/src/gluonts/ext/rotbaum/_types.py b/src/gluonts/ext/rotbaum/_types.py
@@ -25,7 +25,7 @@ class FeatureImportanceResult(BaseModel):
     feat_dynamic_real: List[Union[List[float], float]]
     feat_dynamic_cat: List[Union[List[float], float]]
 
-    @model_validator()
+    @model_validator(mode="before")
     @classmethod
     def check_shape(cls, values):
         """

diff --git a/test/dataset/artificial/test_recipe.py b/test/dataset/artificial/test_recipe.py
@@ -135,7 +135,7 @@ def test_recipe_dataset(recipe) -> None:
             freq="D",
             feat_static_real=[BasicFeatureInfo(name="feat_static_real_000")],
             feat_static_cat=[
-                CategoricalFeatureInfo(name="foo", cardinality=10)
+                CategoricalFeatureInfo(name="foo", cardinality="10")
             ],
             feat_dynamic_real=[BasicFeatureInfo(name="binary_causal")],
         ),