Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return growth stage #352

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

osundwajeff
Copy link
Contributor

@osundwajeff osundwajeff commented Jan 15, 2025

Fix for #329

I updated the fixture file as there was data mismatch in some entries.

@osundwajeff osundwajeff linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13267 12668 95% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f254fd7 by action🐍

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (5b7ef14) to head (f254fd7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   95.37%   95.39%   +0.02%     
==========================================
  Files         231      233       +2     
  Lines       12757    12821      +64     
==========================================
+ Hits        12167    12231      +64     
  Misses        590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osundwajeff osundwajeff marked this pull request as ready for review January 15, 2025 19:04
@danangmassandy danangmassandy merged commit c25e29a into main Jan 16, 2025
4 checks passed
@danangmassandy danangmassandy deleted the gdd-return-growth-stage branch January 16, 2025 00:06
@danangmassandy
Copy link
Collaborator

@osundwajeff I just remember that there is config_id in the gdd matrix, could you create another PR to update the function to receive config_id parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCAS: Identify the growth stage
2 participants