Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding details on how to citation the package and specific models #212

Merged
merged 6 commits into from
May 21, 2024

Conversation

karllark
Copy link
Owner

@karllark karllark commented May 21, 2024

Closes #206
Closes #165

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (604da6a) to head (2911e94).
Report is 79 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           8        8           
  Lines         902      902           
=======================================
  Hits          901      901           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mdecleir mdecleir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small comments.
Otherwise, it looks great.
Thanks for this update!

docs/dust_extinction/references.rst Outdated Show resolved Hide resolved
docs/dust_extinction/references.rst Outdated Show resolved Hide resolved
@mdecleir
Copy link

One additional comment/question. What is the purpose of the reference API: https://dust-extinction.readthedocs.io/en/stable/dust_extinction/reference_api.html?

It looks like some of that page is broken.

@karllark
Copy link
Owner Author

One additional comment/question. What is the purpose of the reference API: https://dust-extinction.readthedocs.io/en/stable/dust_extinction/reference_api.html?

It looks like some of that page is broken.

This page provides the programming interface info. There are supposed to be graphical flow diagrams. Graphviz is clearly not working. Will have to investigate. Not part of this PR. Will open an issue.

@karllark karllark merged commit 842c657 into master May 21, 2024
32 checks passed
@karllark karllark deleted the update_cite branch May 21, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation guidelines B92_MWAvg reference missing
2 participants