VEX related improvements in the build process #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasferrandiz
approved these changes
Jan 9, 2025
|
will approve this after #543 merges |
Signed-off-by: Guilherme Macedo <[email protected]>
macedogm
force-pushed
the
vex-go-build-improvements
branch
from
49e15ba to
71fccc8
Compare
|
@thomasferrandiz I just rebased it. |
Thanks! |
Pull Request Test Coverage Report for Build 12707828919Details
💛 - Coveralls |
|
e2e tests failed, but I cannot trigger a new workflow execution. |
|
Yes they're unstable I don't think that's related to your PR. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Slightly changes the target of
go buildin order to add the right package path inside the binary. This is needed for security scanners to correctly match the binary with a VEX entry.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #541
Special notes for your reviewer (optional):