Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to net-attach v1.7 #451

Closed

Conversation

manuelbuil
Copy link
Collaborator

@manuelbuil manuelbuil commented Apr 12, 2024

What this PR does / why we need it:

Bump network-attachment-definition-client to v1.7.0.

It requires moving to skel.PluginMainFuncs instead of skel.PluginMain

Error: cmd/whereabouts.go:21:2: skel.PluginMain is deprecated: Use github.com/containernetworking/cni/pkg/skel.PluginMainFuncs instead.  (SA1019)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

Signed-off-by: Manuel Buil <[email protected]>
@manuelbuil manuelbuil requested a review from dougbtv as a code owner April 12, 2024 12:58
@manuelbuil
Copy link
Collaborator Author

Superseeded by #452

@manuelbuil manuelbuil closed this Apr 12, 2024
@manuelbuil manuelbuil deleted the movetonetattach17 branch April 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant