-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework cache package - add gcs cache - add cache purge command #750
Merged
matthisholleville
merged 13 commits into
k8sgpt-ai:main
from
matthisholleville:feat/rework-cache
Nov 18, 2023
Merged
feat: rework cache package - add gcs cache - add cache purge command #750
matthisholleville
merged 13 commits into
k8sgpt-ai:main
from
matthisholleville:feat/rework-cache
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
matthisholleville
force-pushed
the
feat/rework-cache
branch
from
November 13, 2023 19:15
9bd38c4
to
8aedb94
Compare
matthisholleville
changed the title
!feat: rework cache package - add gcs cache - add cache purge command
feat: rework cache package - add gcs cache - add cache purge command
Nov 13, 2023
arbreezy
reviewed
Nov 13, 2023
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
β¦ to addOrUpdate Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
4 tasks
Signed-off-by: Matthis Holleville <[email protected]>
4 tasks
AlexsJones
reviewed
Nov 15, 2023
AlexsJones
reviewed
Nov 15, 2023
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
arbreezy
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work
AlexsJones
requested changes
Nov 16, 2023
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Matthis <[email protected]>
AlexsJones
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
k8sgpt cache list
commandβ Checks
βΉ Additional Information
The cache package rework enables the integration of other providers without conflicts in option naming. For example, the integration of
GCS
andS3
uses the same options (bucketName
&Region
), which madeGCS
integration impossible before the rework.The server mode has been tested with the k8sgpt-ai/schemas#19 branch available on buf.build.
The
k8sgpt cache list
command now returns a table, which makes it easier for users to read.The
k8sgpt cache purge
command allows you to delete an object from the cache (local or remote). A future improvement could allow for the deletion of multiple or all cache objects.