fix: naas-space SDK and CLI #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr0p42
reviewed
Jun 25, 2024
| @@ -249,8 +251,8 @@ def delete( | |||
|
|
|||
| def list( | |||
| self, | |||
| page_size: int = typer.Option(0, help="Size of each page of results"), | |||
| page_number: int = typer.Option(0, help="Target page number of results"), | |||
| # page_size: int = typer.Option(0, help="Size of each page of results"), | |||
There was a problem hiding this comment.
hi, this is not yet implemented in API
| @@ -52,8 +52,9 @@ def get_space_by_name(self, name): | |||
| return self._handle_get_response(api_response) | |||
|
|
|||
| @BaseAPIAdaptor.service_status_decorator | |||
| def list_spaces(self, page_size, page_number) -> dict: | |||
| _url = f"{self.host}/space/?page_size={page_size}&page_number={page_number}" | |||
There was a problem hiding this comment.
hi, this is not yet implemented in API
|
Pytest are not passing also |
…ing' into 2522-feat-create-notebooks-for-crud-operations-using-naas-python-for-spaces
|
@Dr0p42 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue resolve : https://github.com/jupyter-naas/awesome-notebooks/issues/2522#issue-2306303965