-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💽 Add site options to each page #1536
Conversation
🦋 Changeset detectedLatest commit: 62a5836 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validating options against the site template looks good and makes sense.
My only concern, though, is introducing site
options, alongside the existing options
field. In my mind, options
covers all template-specific options including both site and static export templates... I'm worried about confusion around putting an option in the wrong options location.
if (defined(value.site)) { | ||
// These are validated later based on the siteTemplate | ||
// At this point, they just need to be an object | ||
output.site = validateObject(value.site, incrementOptions('site', opts)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this overlap with options
, which already exists per-page?
Chatting some with @rowanc1 - we will keep the new As for Also note, I think this PR addresses: #1450 |
This enables per-page options for the site.
Picked up in the theme in jupyter-book/myst-theme#472