Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Style scrollbar #508

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

jnywong
Copy link
Contributor

@jnywong jnywong commented Dec 17, 2024

Closes jupyter-book/mystmd#1672.

Here is what the changes look like in both light and dark mode for a Chromium-based browser:

Screenshot 2024-12-17 at 09 44 37
Screenshot 2024-12-17 at 09 44 41

No changes were needed for Firefox, hence the use of -webkit-scrollbar only.

Screenshot 2024-12-17 at 09 48 19

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 3b06af1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rowanc1 rowanc1 changed the title Style scrollbar 🎨 Style scrollbar Dec 17, 2024
@rowanc1 rowanc1 merged commit ca8893f into jupyter-book:main Dec 17, 2024
2 checks passed
@agoose77
Copy link
Collaborator

I think the Chromium styling is perhaps better than the Firefox after this PR w.r.t. the background colour of the scrollbar. Should we follow up and touch that too?

@choldgraf
Copy link
Contributor

Jenny your website looks awesome!

@jnywong
Copy link
Contributor Author

jnywong commented Dec 17, 2024

I think the Chromium styling is perhaps better than the Firefox after this PR w.r.t. the background colour of the scrollbar. Should we follow up and touch that too?

I can easily go back in and take a look at that. I initially decided against it because I wanted to make CSS changes as minimal as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark/light mode scrollbar of primary sidebar
4 participants