📌 Fix location to executable .md files in Thebe
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e07326e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (match) { | ||
| console.debug('session starter match:', match); | ||
| // Choose an arbitrary suffix, not important | ||
| path = `${match[1]}/${pageSlug}-${notebookSlug}.ipynb`; |
There was a problem hiding this comment.
yes, it's the first part of the path here that is important, not the filename - but it's fine (an consistent) that this appears as ipynb in the jupyter lab session manager. Having a .md in the session manager is weird? (i.e. that never occurs even in when people are using jupytext within jupyter lab? or does it).
If we wanted could preserve the extension from the incoming location, secondary to the fix though.
stevejpurves
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with
.mdfiles that contain kernelspecs currently report that thecwdof running kernels in Thebe (via the power-button UX) is incorrect.Digging into this, Thebe assumes that we have an
ipynbfile when performing filepath substitution during session provisioning. This means that thecwdis incorrect for.mdfiles.This PR relaxes the extension check, and introduces a maybe-incorrect
.ipynbextension because it's ultimately an arbitrary filename, and we don't then need to use path-handling routines.