-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Use Remix v2 (Classic Compiler) (2) #409
base: main
Are you sure you want to change the base?
Conversation
135c49f
to
9003a00
Compare
@rowanc1 can you elaborate on the redirect bug you saw? Was it for deployed static sites rather than those run from |
If you npx serve the built html, landing on any page would go into an infinite reload loop. It is very obvious. It may only be the case if you change the base path? E.g. BASE_URL=/_build/html And then serve from the project directory. The json that remix sends us seen to be invalid, because we changed it, and then it goes into a loop. Possible that that has been fixed as we are skipping many versions. |
I can confirm that I'm seeing the continuous loop behaviour that you reported for 1.1.18 in version 2.x. It looks like we might need to consider the other routes to static exports (like SSG SPA that I linked previously). |
Very unfortunate. :( |
I have a stupid idea for upgrading to v2 before we have implemented SSG - mpa-spa. Could we run the MyST server at the same base path such that the hydrated document matches the SSR? |
Maybe? I think that would be just changing the request coming in (i.e. _build/html/slug) and then in the loader ensuring that matches. |
727368e
to
c265b98
Compare
This PR builds upon #408 and actually switches to Remix V2, using the classic remix compiler. A future PR would need to be used to pull in the Vite compiler.
This PR doesn't try to fix the problem with static exports.