Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚥 allow CONTENT_CDN host to be spec'ed #346

Closed
wants to merge 5 commits into from

Conversation

stevejpurves
Copy link
Contributor

fixing #342

This allows the hostname used in the CONTENT_CDN to be specified independent of PORT or HOST.

Note trying to use HOST for this purpose is problematic as the express development server attempts to bind to this and fails, we really just want to influence rewriting on urls to static assets, so we are adding CONTENT_CDN_HOST in a similar vein to how CONTENT_CDN_PORT is used.

A parallel change in mystmd is needed in order to add CONTENT_CDN_HOST based on HOST when starting the dev server (potentially only when --keep-host is used?)

@stevejpurves stevejpurves requested a review from rowanc1 April 1, 2024 20:46
@stevejpurves
Copy link
Contributor Author

tested this by setting a name on /etc/hosts and then HOST=http://noplacelikehome myst start --keep-host with the output from make build-book copied into _build/templates folder

image

@rowanc1
Copy link
Member

rowanc1 commented Sep 13, 2024

I think the approach in #468 is a bit cleaner. Allows to be set without a port. I think this also is a solution for #342.

@rowanc1 rowanc1 closed this Sep 13, 2024
@rowanc1 rowanc1 deleted the fix/static-keep-host branch September 13, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants