🚥 allow CONTENT_CDN host to be spec'ed #346
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #342
This allows the hostname used in the
CONTENT_CDN
to be specified independent ofPORT
orHOST
.Note trying to use
HOST
for this purpose is problematic as the express development server attempts to bind to this and fails, we really just want to influence rewriting on urls to static assets, so we are addingCONTENT_CDN_HOST
in a similar vein to howCONTENT_CDN_PORT
is used.A parallel change in
mystmd
is needed in order to addCONTENT_CDN_HOST
based onHOST
when starting the dev server (potentially only when--keep-host
is used?)