🧹 remove unneeded logic to transform thebe options and improve naming #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs jupyter-book/mystmd#788 to come in and a |
rowanc1
reviewed
Nov 29, 2023
stevejpurves
force-pushed
the
mnt/reduce-thebe-opt-rework
branch
from
36e8fad to
150247e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that
myst-frontmatteris doing more of the thebe options transformation work the logic in here to go from frontmatter to workable thebe options can be reduced.UPDATE: this pr now contains more refactoring around the thebe providers and relies on the loaders to resolve projects where needed, leaving the ProjectProvider to provide a useful default and avoid excessive drilling.
tested on book and article theme, with single and multi-project sites