Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗿always apply overrides and allow for undefined options #257

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

stevejpurves
Copy link
Contributor

@stevejpurves stevejpurves commented Nov 9, 2023

Prior to this change, it was not possible to completely override thebe options if there was no thebe|jupyter field set in the frontmatter at all.

This remedies that and gives much more flexbility to consumers.

  • full build working
  • book theme working
  • article theme working

@stevejpurves stevejpurves requested a review from rowanc1 November 9, 2023 11:35
@stevejpurves stevejpurves marked this pull request as draft November 10, 2023 14:08
@stevejpurves stevejpurves self-assigned this Nov 10, 2023
* 💖 fix up toolbar busy state

* 🙈 ignore service worker in themes

* 👊🏽 thebe

* 📕 changeset

* 🗂 added ProjectProvider

* 👷🏻‍♂️building with project prop
@stevejpurves stevejpurves marked this pull request as ready for review November 27, 2023 15:00
@stevejpurves stevejpurves merged commit e5fc635 into main Nov 28, 2023
2 checks passed
@stevejpurves stevejpurves deleted the fix/thebe-overrides branch November 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant