🎨 Fix citation link styles (#252)

- Add `<span>` as a known element type
jupyter-book · Oct 24, 2023 · 6db9952 · 6db9952
1 parent 29fc03a
commit 6db9952
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/fifty-bears-guess.md b/.changeset/fifty-bears-guess.md
@@ -0,0 +1,5 @@
+---
+'myst-to-react': patch
+---
+
+Add span and fix citation link styles
diff --git a/packages/myst-to-react/src/basic.tsx b/packages/myst-to-react/src/basic.tsx
@@ -43,6 +43,7 @@ type CaptionNumber = {
 
 type BasicNodeRenderers = {
   text: NodeRenderer<spec.Text>;
+  span: NodeRenderer<GenericNode>;
   strong: NodeRenderer<spec.Strong>;
   emphasis: NodeRenderer<spec.Emphasis>;
   link: NodeRenderer<spec.Link>;
@@ -82,6 +83,14 @@ const BASIC_RENDERERS: BasicNodeRenderers = {
   text({ node }) {
     return <>{node.value}</>;
   },
+  span({ node }) {
+    // style={node.style}
+    return (
+      <span>
+        <MyST ast={node.children} />
+      </span>
+    );
+  },
   delete({ node }) {
     return (
       <del>

diff --git a/packages/myst-to-react/src/cite.tsx b/packages/myst-to-react/src/cite.tsx
@@ -54,7 +54,7 @@ export const Cite = ({
             {children}
           </a>
         )}
-        {!doiUrl && children}
+        {!doiUrl && <span className="hover-link">{children}</span>}
       </cite>
     </HoverPopover>
   );