Skip to content

Commit

Permalink
Switch from triplet only tracks to all tracks, to avoid problems with…
Browse files Browse the repository at this point in the history
… tracking particles (and b/c it makes more sense)
  • Loading branch information
mandrenguyen committed Jul 24, 2013
1 parent 214ab73 commit d747509
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
6 changes: 4 additions & 2 deletions Validation/RecoHI/plugins/HitPixelLayersTPSelector.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class HitPixelLayersTPSelector
std::vector<bool> pixelHitPattern( const TrackingParticleRef& simTrack, const TrackerTopology *tTopo )
{
std::vector<bool> hitpattern(5,false); // PXB 0,1,2 PXF 0,1

/*
#warning "This file has been modified just to get it to compile without any regard as to whether it still functions as intended"
#ifdef REMOVED_JUST_TO_GET_IT_TO_COMPILE__THIS_CODE_NEEDS_TO_BE_CHECKED
for(std::vector<PSimHit>::const_iterator simHit = simTrack->pSimHit_begin();simHit!= simTrack->pSimHit_end();simHit++){
Expand All @@ -114,7 +114,9 @@ class HitPixelLayersTPSelector
}// end simhit loop
#endif

*/
// Indeed this no longer functions as intended, but this code should no longer be accessed, since tripletSeedOnly_ has been changed to False. We will clean up when we figure out how to do this properly - Matt Nguyen, 24/7/2013

return hitpattern;
}

Expand Down
12 changes: 6 additions & 6 deletions Validation/RecoHI/python/TrackValidationHeavyIons_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
# setup multi-track validator
from Validation.RecoTrack.MultiTrackValidator_cff import *
hiTrackValidator = multiTrackValidator.clone(
label_tp_effic = cms.InputTag("findableSimTracks"),
label_tp_effic = cms.InputTag("primaryChgSimTracks"),
label_tp_fake = cms.InputTag("cutsTPFake"),
signalOnlyTP = cms.bool(False),
skipHistoFit = cms.untracked.bool(True), # done in post-processing
Expand All @@ -40,11 +40,11 @@

# track prevalidation
hiTrackPrevalidation = cms.Sequence(
findableSimTracks
* cutsTPFake
* cutsRecoTracks
* cutsRecoTracksHP
)
primaryChgSimTracks
* cutsTPFake
* cutsRecoTracks
* cutsRecoTracksHP
)

# track validation sequence
hiTrackValidation = cms.Sequence( hiTrackValidator )
1 change: 1 addition & 0 deletions Validation/RecoHI/python/selectSimTracks_cff.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import FWCore.ParameterSet.Config as cms

# Not actually functioning at the moment, use primaryChgSimTracks - Matt Nguyen, 24/7/2013
findableSimTracks = cms.EDFilter("HitPixelLayersTPSelection",
src = cms.InputTag("mix","MergedTrackTruth"),
tripletSeedOnly = cms.bool(True),
Expand Down

0 comments on commit d747509

Please sign in to comment.