Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jvm config for maven required for java 16+ #1280

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add jvm config for maven required for java 16+ #1280

merged 1 commit into from
Jan 7, 2025

Conversation

ccleva
Copy link
Contributor

@ccleva ccleva commented Jan 7, 2025

Thanks for contributing.

Description

Added maven jvm options file required for using the git-code-format-maven-plugin on Java 16+. See https://github.com/Cosium/git-code-format-maven-plugin?tab=readme-ov-file#jdk-16-peculiarities

Testing

To be tested on java 11

@ccleva ccleva marked this pull request as ready for review January 7, 2025 17:58
@ccleva ccleva mentioned this pull request Jan 7, 2025
Merged
1 task
benmccann
benmccann approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@benmccann benmccann merged commit a1c9e2d into jtablesaw:master Jan 7, 2025
7 checks passed
@ccleva ccleva deleted the add_mvn_jvm_config branch January 10, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccleva @benmccann