Fix #657 incorrect encoding of embedded-recursive types and overlapping tags #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to explore how to fix #657 .
A simple fix to recursive embedded types is to add recursion check.
This, however, breaks other test cases.
I found that it is hard to fix the problem by changing the current
resolveConflictBindingimplementation, because it does it without field information, while Go'sdominantFielddoes it with field info.Adding the overlapping-field-resolver implementation almost identical to that of the std's
encoding/json, of course, fixes the problem.This PR introduces significant changes to the code base (at least it's not like 50 lines fix).
So this might not be suitable for the goal of this library.