. d Fix ObjC presented/dismissed vc examples to use XCTAssertIdentical

jonreid · Sep 30, 2024 · 263a2dd · 263a2dd
1 parent e58d38a
commit 263a2dd
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata b/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
diff --git a/ObjCSample/Tests/ViewControllerAlertTests.m b/ObjCSample/Tests/ViewControllerAlertTests.m
@@ -44,7 +44,7 @@ - (void)test_tappingShowAlertButton_shouldPresentAlert
 
     XCTAssertEqual(alertVerifier.presentedCount, 1, @"presented count");
     XCTAssertEqual(alertVerifier.preferredStyle, UIAlertControllerStyleAlert, @"preferred style");
-    XCTAssertEqual(alertVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(alertVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertTrue(alertVerifier.animated, @"animated");
     XCTAssertEqualObjects(alertVerifier.title, @"Title", @"title");
     XCTAssertEqualObjects(alertVerifier.message, @"Message", @"message");
@@ -56,7 +56,7 @@ - (void)test_tappingShowActionSheetButton_shouldPresentActionSheet
 
     XCTAssertEqual(alertVerifier.presentedCount, 1, @"presented count");
     XCTAssertEqual(alertVerifier.preferredStyle, UIAlertControllerStyleActionSheet, @"preferred style");
-    XCTAssertEqual(alertVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(alertVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertTrue(alertVerifier.animated, @"animated");
     XCTAssertEqualObjects(alertVerifier.title, @"Title", @"title");
     XCTAssertEqualObjects(alertVerifier.message, @"Message", @"message");

diff --git a/ObjCSample/Tests/ViewControllerPresentationTests.m b/ObjCSample/Tests/ViewControllerPresentationTests.m
@@ -49,7 +49,7 @@ - (void)test_tappingSeguePresentModalButton_shouldPresentNextViewControllerWithG
     [sut.seguePresentModalButton sendActionsForControlEvents:UIControlEventTouchUpInside];
 
     XCTAssertEqual(presentationVerifier.presentedCount, 1, @"presented count");
-    XCTAssertEqual(presentationVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(presentationVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertTrue(presentationVerifier.animated, @"animated");
     if (![presentationVerifier.presentedViewController isKindOfClass:[StoryboardNextViewController class]])
     {
@@ -70,7 +70,7 @@ - (void)test_tappingSegueShowButton_shouldShowNextViewControllerWithRedBackgroun
     [sut.segueShowButton sendActionsForControlEvents:UIControlEventTouchUpInside];
 
     XCTAssertEqual(presentationVerifier.presentedCount, 1, @"presented count");
-    XCTAssertEqual(presentationVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(presentationVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertTrue(presentationVerifier.animated, @"animated");
     if (![presentationVerifier.presentedViewController isKindOfClass:[StoryboardNextViewController class]])
     {
@@ -87,7 +87,7 @@ - (void)test_tappingCodeModalButton_shouldPresentNextViewControllerWithPurpleBac
     [sut.codePresentModalButton sendActionsForControlEvents:UIControlEventTouchUpInside];
 
     XCTAssertEqual(presentationVerifier.presentedCount, 1, @"presented count");
-    XCTAssertEqual(presentationVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(presentationVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertTrue(presentationVerifier.animated, @"animated");
     if (![presentationVerifier.presentedViewController isKindOfClass:[CodeNextViewController class]])
     {

diff --git a/README.md b/README.md
@@ -98,7 +98,7 @@ func test_showAlert_alertShouldHaveTitle() {
     XCTAssertEqualObjects(alertVerifier.message, @"How are you?", @"message");
     XCTAssertEqual(alertVerifier.animated, YES, @"animated");
     XCTAssertEqual(alertVerifier.preferredStyle, UIAlertController.Style.alert, @"preferred style");
-    XCTAssertEqual(alertVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(alertVerifier.presentingViewController, sut, @"presenting view controller");
     XCTAssertEqual(alertVerifier.actions.count, 2, @"actions count);
     XCTAssertEqualObjects(alertVerifier.actions[0].title, @"OK", @"first action");
     XCTAssertEqual(alertVerifier.actions[0].style, UIAlertActionStyleDefault, @"first action");
@@ -180,7 +180,7 @@ func test_presentedVC_shouldHaveSpecialSettingHello() {
 
     XCTAssertEqual(presentationVerifier.presentedCount, 1, @"presented count");
     XCTAssertTrue(presentationVerifier.animated, @"animated");
-    XCTAssertEqual(presentationVerifier.presentingViewController, sut, @"presenting view controller");
+    XCTAssertIdentical(presentationVerifier.presentingViewController, sut, @"presenting view controller");
     if (![presentationVerifier.presentedViewController isKindOfClass:[MyViewController class]])
     {
         XCTFail(@"Expected MyViewController, but was %@", presentationVerifier.presentedViewController);
@@ -261,7 +261,7 @@ func test_dismissingVC() {
 
     XCTAssertEqual(dismissalVerifier.dismissedCount, 1, @"dismissed count");
     XCTAssertTrue(dismissalVerifier.animated, @"animated");
-    XCTAssertEqual(dismissalVerifier.presentingViewController, sut, @"dismissed view controller");
+    XCTAssertIdentical(dismissalVerifier.dismissedViewController, sut, @"dismissed view controller");
 }
 ```