[WIP] Remove hardcoded celltypes #970
Open
+189
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "toy" commit solely for the purpose of creating a new upstream branch.
removing hard coding in _create_cell_coords function and linking this with __init__ in class Network fixing the _create_cell_coords refactoring _create_cell_coords refactoring _create_cell_coords contd removing cell_name from 466 argument correcting styling error and fixing self.post_dict in class network making different corrections in network fixed line 463 working with line 465 network.py still working with line 407 adding a space added self before cell_types commented line 404 and added self to cell_types to make it an attribute to instance network de-indenting line 115 for pos_dict to get input from the whole code de-indenting lines 103 thru 115 in network corrected names of cells to match cell.name added a comment on the plan lines 81 thru 86 in network_models changing cell name to L2_basket added a rename_cell function and _rename_basket subfunction WIP making some re-organizing of comments to rename_cell function rename is working with gid_ranges ordered, still working on visualization fixing a typo modified rename function to order cell_types items visualization raster working and colors matching fixing extra white spaces etc... . Updating plot cell function WIP maintain original order in net.gid_ranges only modify net.gid_ranges in loop to simplify rename_cell cleaning up code modifying the discription removing extra lines fixed color_map in plot_raster marker set to o for all cells adding tests aethetic modification correct elif or error correcting a typo correcting pytests updating pytest fixing network tests cell-repsonse test _add_cell-type
|
It is known that the tests are failing "across the board" after merging in #702 's prior work. These are mostly tied to new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @katduecker @ntolley @wagdy88
Due to the complexity and remaining work of #702, and the fact that some in the Jones lab are increasingly in need of this functionality, I've created a new branch here on "upstream" https://github.com/jonescompneurolab/hnn-core/tree/refactor-hardcoded-celltypes . This way, people can feel free to contribute individual commits as needed, instead of someone else having to manage contributions to their own fork's branch. The first thing I will do is get https://github.com/wagdy88/hnn-core/tree/refactor_cell_name into this branch, and then we can move forward.
Note that since this is a feature branch, rebases and history-rewriting ARE allowed, however! Please try to code so as to avoid the need for this, and please indicate to others when you plan to
force-pushand rewrite history. If you run into a discrepancy and want help, then please contact me.This first commit is a "toy" commit solely for the purpose of creating a new upstream branch, and can be ignored.