Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build pyproj toml #948

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: update pyproject.toml
  • Loading branch information
gtdang committed Nov 21, 2024
commit 165b44ed110f05a7327edd33516423be56c5e09d
9 changes: 3 additions & 6 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -6,19 +6,17 @@ build-backend = "setuptools.build_meta"
name = "hnn-core"
dynamic = ["version"]
authors = [
{ name="Stephanie Jones", email="[email protected]" },
{ name="Mainak Jas", email="[email protected]" },
{ name="Nicholas Tolley", email="[email protected]" },
{ name="Ryan Thorpe", email="[email protected]" },
{ name="Stephanie Jones", email="[email protected]" },
]
maintainers = [
{name="George Dang", email="[email protected]"},
{name="Dylan Daniels", email="[email protected]"},

]
description = "Tools for biophysical simulation of a cortical column using Neuron"
readme = "README.rst"
requires-python = ">=3.8"
classifiers = [
"Programming Language :: Python :: 3",
"License :: OSI Approved :: BSD (3-clause)",
@@ -31,6 +29,7 @@ classifiers = [
"Operating System :: Unix",
"Operating System :: MacOS",
]
requires-python = ">=3.8"
dependencies = [
"numpy >= 1.14",
"matplotlib >= 3.5.3",
@@ -59,11 +58,9 @@ hnn-gui = "hnn_core.gui.gui:launch"
"Source Code" = "http://github.com/jonescompneurolab/hnn-core"

[tool.setuptools]
packages = ["hnn_core"]
include-package-data = true

[tool.setuptools.packages.find]
where = ["hnn_core"]

[tool.setuptools.dynamic]
version = {attr = "hnn_core.__version__"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this actually work? I suspect it will break ...

Copy link
Collaborator

@gtdang gtdang Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the documentation on specifying dynamic metadata. I think it should work, it's pretty commonplace with toml specification. Just need the version defined in the top-level __init__.py in the package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try ... I think hnn_core.__version__ is not defined before installation. Maybe it works !