[ENH] In GUI, flip the distal drives when plotting the input histogram #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tograms in the GUI
dylansdaniels
changed the title
|
@ntolley I haven't added tests yet but otherwise this is ready for class |
Since the addition of inverted spike histograms requires the use of two Axes objects, we need to change a few small things: 1. Add a label to our new, second Axes object upon creation in `viz` 2. Use this label to completely remove the second Axes object when "Clear axis" button is pressed 3. Since axes of type "input histogram" are now going to have 2 Axes object, while most others will only have 1, we need to make an exception in the testing. I have done so in `tests/test_gui.py` along with a small refactor. The test refactor consists of moving the content of `test_gui_adaptive_spectrogram` into just another case of the `test_gui_visualization` test. Additionally, all tests in that test now take place in a brand-new "Blank single figure", so that their total axes number do NOT include those of axes that are not the current `viz_type` being tested (which was the case before).
fix: accomodate invert-hist second Axes obj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.