Fix bug triggered by calling slider.update()

Would render slider unresponsive
johnwalley · Oct 16, 2018 · fcc9f3f · fcc9f3f
1 parent e35097e
commit fcc9f3f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "d3-simple-slider",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Renders an SVG slider",
   "keywords": [
     "d3",

diff --git a/src/slider.js b/src/slider.js
@@ -194,9 +194,8 @@ function slider() {
       updateValue(newValue, true);
     }
 
-    textSelection = selection.select(".parameter-value text");
-    handleSelection = selection.select('.parameter-value');    
-
+    textSelection = selection.select('.parameter-value text');
+    handleSelection = selection.select('.parameter-value');
   }
 
   function fadeTickText() {
@@ -250,19 +249,19 @@ function slider() {
     }
   }
 
-
   function updateHandle(newValue, animate) {
     animate = typeof animate !== 'undefined' ? animate : false;
 
     if (animate) {
-      handleSelection = handleSelection
+      handleSelection
         .transition()
         .ease(easeQuadOut)
-        .duration(UPDATE_DURATION);
+        .duration(UPDATE_DURATION)
+        .attr('transform', 'translate(' + scale(newValue) + ',0)');
+    } else {
+      handleSelection.attr('transform', 'translate(' + scale(newValue) + ',0)');
     }
 
-    handleSelection.attr('transform', 'translate(' + scale(newValue) + ',0)');
-
     if (displayValue) {
       textSelection.text(displayFormat(newValue));
     }
@@ -302,7 +301,7 @@ function slider() {
     if (!arguments.length) return displayFormat;
     displayFormat = _;
     return slider;
-  };  
+  };
 
   slider.ticks = function(_) {
     if (!arguments.length) return ticks;
@@ -330,7 +329,7 @@ function slider() {
     updateValue(newValue, false);
 
     return slider;
-  };  
+  };
 
   slider.default = function(_) {
     if (!arguments.length) return defaultValue;