Skip to content

Commit

Permalink
release: hot fix to 1.0.3 (#66)
Browse files Browse the repository at this point in the history
* fix: phone call (#61)

* fix: call + sms phone format

* chore: update TASKS

* fix: bad state error (#62)

* chore: UI clean up

I somehow couldn't reproduce the bug. I ended up cleaning up some UI.

* chore: update TASKS

* refactor: redux reset store on logout (#63)

* chore: first look

* chore: code clean up

* chore(redux): second draft

* feat(redux): clean up store on logout

* feat: reset store on logout

* chore: update TASKS

* feat: version check (#64)

* feat: version check

* chore: update TASKS

* feat: bump to 1.0.3

* fix: reference upload (#65)

* chore: code clean up

* fix: reference upload

Fixes the bad state as well. Turns out firstWhere throws on Empty.

* chore: update TASKS
  • Loading branch information
jogboms authored Jul 21, 2018
1 parent ae00c4e commit 021776c
Show file tree
Hide file tree
Showing 39 changed files with 642 additions and 447 deletions.
7 changes: 6 additions & 1 deletion TASKS.todo
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,14 @@ PENDING:
☐ On account create, send personal email + email to user @high
☐ personalize measurements w/ account @critical
☐ indicator for premium accounts @today
☐ reference upload issue @critical

COMPLETED:
✔ reference upload issue @critical @done(18-07-21 16:40)
✔ stats image count on job update image @today @done(18-07-21 15:49)
✔ check for outdated version + template @today @done(18-07-21 15:40)
✔ reset local store on logout @critical @done(18-07-21 14:18)
✔ on dismiss contact creation, bad state error @critical @done(18-07-21 10:18)
✔ phone number call + sms issue @critical @done(18-07-21 09:59)
✔ fix homepage height issue @today @done(18-07-20 20:39)
✔ sort + search jobs & contacts @today @done(18-07-20 20:00)
✔ friendly error on log in @today @done(18-07-20 19:34)
Expand Down
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ keystoreProperties.load(new FileInputStream(keystorePropertiesFile))

ext.versionMajor = 1
ext.versionMinor = 0
ext.versionPatch = 2
ext.versionPatch = 3
ext.versionClassifier = "beta"
ext.isSnapshot = false
ext.minimumSdkVersion = 16
Expand Down
5 changes: 4 additions & 1 deletion lib/models/settings.dart
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
class SettingsModel {
String premiumNotice;
final String premiumNotice;
final String versionName;

SettingsModel({
this.premiumNotice,
this.versionName,
});

factory SettingsModel.fromJson(Map<String, dynamic> json) {
assert(json != null);
return new SettingsModel(
premiumNotice: json['premiumNotice'],
versionName: json['versionName'],
);
}
}
2 changes: 1 addition & 1 deletion lib/pages/contacts/contacts.dart
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class _ContactsPageState extends State<ContactsPage> {
AppBar buildAppBar(TMTheme theme, ContactsViewModel vm) {
return appBar(
context,
title: "Clients",
title: "Contacts",
actions: <Widget>[
new IconButton(
icon: new Icon(
Expand Down
4 changes: 2 additions & 2 deletions lib/pages/contacts/ui/contact_appbar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class ContactAppBarState extends State<ContactAppBar> {
ContactsEditPage(contact: widget.contact),
);
case Choice.SendText:
return sms(int.parse(widget.contact.phone));
return sms(widget.contact.phone);
default:
break;
}
Expand Down Expand Up @@ -77,7 +77,7 @@ class ContactAppBarState extends State<ContactAppBar> {
),
appBarIcon(
icon: Icons.call,
onTap: () => call(int.parse(widget.contact.phone)),
onTap: () => call(widget.contact.phone),
),
new PopupMenuButton<Choice>(
icon: Icon(Icons.more_vert, color: Colors.white),
Expand Down
2 changes: 1 addition & 1 deletion lib/pages/contacts/ui/contacts_filter_button.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class ContactsFilterButton extends StatelessWidget {
SortType.recent,
),
buildTextOption(
"Reset Sort",
"No Sort",
SortType.reset,
),
],
Expand Down
9 changes: 6 additions & 3 deletions lib/pages/contacts/ui/contacts_list_item.dart
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ class ContactsListItem extends StatelessWidget {
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
iconCircle(Icons.call, () => call(int.parse(contact.phone))),
iconCircle(Icons.message, () => sms(int.parse(contact.phone))),
iconCircle(Icons.call, () => call(contact.phone)),
iconCircle(Icons.message, () => sms(contact.phone)),
],
);

Expand All @@ -97,7 +97,10 @@ class ContactsListItem extends StatelessWidget {
() => TMNavigate(context, ContactPage(contact: contact)),
leading: avatar(),
title: title,
subtitle: Text(pending >= 1 ? "$pending pending" : "No pending wears",
subtitle: Text(
pending >= 1
? "$pending pending"
: "${contact.totalJobs > 0 ? contact.totalJobs : 'none'} completed",
style: TextStyle(fontSize: 14.0, color: kTextBaseColor)),
trailing: showActions ? icons : null,
);
Expand Down
34 changes: 19 additions & 15 deletions lib/pages/gallery/gallery_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -71,21 +71,25 @@ class MyAppBar extends StatelessWidget implements PreferredSizeWidget {
icon: Icon(Icons.arrow_back),
),
Expanded(child: SizedBox()),
IconButton(
icon: Icon(
Icons.work,
color: Colors.white,
),
onPressed: () => TMNavigate(context, JobPage(job: job)),
),
IconButton(
icon: Icon(
Icons.person,
color: Colors.white,
),
onPressed: () =>
TMNavigate(context, ContactPage(contact: contact)),
),
job != null
? IconButton(
icon: Icon(
Icons.work,
color: Colors.white,
),
onPressed: () => TMNavigate(context, JobPage(job: job)),
)
: SizedBox(),
contact != null
? IconButton(
icon: Icon(
Icons.person,
color: Colors.white,
),
onPressed: () =>
TMNavigate(context, ContactPage(contact: contact)),
)
: SizedBox(),
IconButton(
icon: Icon(
Icons.share,
Expand Down
3 changes: 3 additions & 0 deletions lib/pages/homepage/home_view_model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'package:redux/redux.dart';
import 'package:tailor_made/models/account.dart';
import 'package:tailor_made/models/contact.dart';
import 'package:tailor_made/redux/actions/account.dart';
import 'package:tailor_made/redux/actions/main.dart';
import 'package:tailor_made/redux/states/account.dart';
import 'package:tailor_made/redux/states/contacts.dart';
import 'package:tailor_made/redux/states/main.dart';
Expand Down Expand Up @@ -35,4 +36,6 @@ class HomeViewModel extends StatsViewModel {
void onReadNotice() => store.dispatch(OnReadNotice(payload: account));

void onSkipedPremium() => store.dispatch(OnSkipedPremium());

void logout() => store.dispatch(OnLogoutEvent());
}
Loading

0 comments on commit 021776c

Please sign in to comment.