Skip to content

Commit

Permalink
ci: Fix release workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
joeyparrish committed Jan 6, 2025
1 parent 12e2367 commit e26bd1d
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 3 deletions.
26 changes: 24 additions & 2 deletions .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
# Create/update release PR
- uses: googleapis/release-please-action@v4
- uses: google-github-actions/release-please-action@v4
id: release
with:
# These are the necessary parameters for releasing multiple packages
Expand All @@ -27,10 +27,32 @@ jobs:
manifest-file: .release-please-manifest.json
monorepo-tags: true

- name: Compute tag name
id: compute
if: steps.release.outputs.releases_created
run: |
# For a monorepo, there may be multiple tags, so outputs.tag_name is
# only used for releases of the root component. To get the tag name
# generally, we need to check outputs.paths_released, and possibly
# use that to construct the tag name. This seems like a major
# failing of release-please-action, which could have a simple output
# with an arbitrary tag name for situations like this.
json="${{ toJSON(steps.release.outputs) }}"
# This is a tag from the root component, if any.
tag_name=$(echo "$json" | jq -r .tag_name)
if [[ "$tag_name" == "" ]]; then
# We don't care about every single tag. We just care about one tag
# so we can check out the appropriate code from the repo. So grab
# path [0].
path=$(echo "$json" | jq -r .paths_released[0])
tag_name=$(echo "$json" | jq -r ".$path--tag_name")
fi
echo "tag_name=$tag_name" >> $GITHUB_OUTPUT
- name: Checkout code
uses: actions/checkout@v4
with:
ref: refs/tags/${{ steps.release.outputs.tag_name }}
ref: refs/tags/${{ steps.compute.outputs.tag_name }}
persist-credentials: false
if: steps.release.outputs.releases_created

Expand Down
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"backends/chromecast": "2.0.0",
"backends/chromeos": "1.0.4",
"backends/tizen": "2.0.0",
"backends/xboxone": "1.0.5"
"backends/xboxone": "1.0.4"
}

0 comments on commit e26bd1d

Please sign in to comment.