Support multiple architectures by going back to single-stage build #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachlipp
had a problem deploying
to
docker_jbbp
GitHub Actions
Failure
zachlipp
changed the title
zachlipp
had a problem deploying
to
docker_jbbp
GitHub Actions
Failure
joachimbbp
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we'd be catching these locally, but with 1+hr builds, I think we've been reluctant to run full local tests before using CI.
This succeeds locally. We'll see if we need something else for CI
UPDATE
After in-person discussion, @joachimbbp and I decided we should have a C compiler in our image such that people can reliably install Python packages that build on the host (e.g.
numpy,pandas). This also drastically simplifies multi-architecture support because we're no longer trying to copy and paste from directories that only exist on ARM build targets.