fix(scaffolding): allow TS Server to see Vitest globals on tests

jkomyno · Sep 16, 2024 · c9bf222 · c9bf222
1 parent 24d3247
commit c9bf222
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -8,9 +8,6 @@
     "build": "turbo run build",
     "clean": "turbo run clean",
     "watch": "turbo run watch",
-    "prettier-check": "turbo run prettier-check",
-    "prettier-write": "turbo run prettier-write",
-    "typecheck": "turbo run typecheck",
     "lint:ci": "turbo run lint:ci",
     "lint": "turbo run lint",
     "test": "pnpm -r --if-present test",

diff --git a/packages/common-utils/package.json b/packages/common-utils/package.json
@@ -13,8 +13,8 @@
   },
   "scripts": {
     "clean": "rimraf build",
-    "build": "pnpm clean && tsc",
-    "typecheck": "tsc",
+    "prebuild": "pnpm clean",
+    "build": "tsc --build tsconfig.build.json",
     "lint:ci": "biome ci",
     "lint": "biome check --fix --unsafe",
     "test": "vitest --workspace ../../vitest.workspace.ts run",

diff --git a/packages/common-utils/tsconfig.build.json b/packages/common-utils/tsconfig.build.json
@@ -0,0 +1,7 @@
+{
+  "extends": "../../tsconfig.base.node.json",
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "build"
+  }
+}
diff --git a/packages/common-utils/tsconfig.json b/packages/common-utils/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "extends": "../../tsconfig.base.node.json",
-  "include": ["src"],
+  "include": ["src", "__tests__"],
   "compilerOptions": {
     "outDir": "build"
   }

diff --git a/packages/example/package.json b/packages/example/package.json
@@ -6,8 +6,8 @@
   "main": "./build/index.js",
   "scripts": {
     "clean": "rimraf build",
-    "build": "pnpm clean && tsc",
-    "typecheck": "tsc",
+    "prebuild": "pnpm clean",
+    "build": "tsc --build tsconfig.build.json",
     "lint:ci": "biome ci",
     "lint": "biome check --fix --unsafe",
     "test:unit": "vitest --workspace ../../vitest.workspace.ts --project unit run"

diff --git a/packages/example/tsconfig.build.json b/packages/example/tsconfig.build.json
@@ -0,0 +1,7 @@
+{
+  "extends": "../../tsconfig.base.node.json",
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "build"
+  }
+}
diff --git a/packages/example/tsconfig.json b/packages/example/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "extends": "../../tsconfig.base.node.json",
-  "include": ["src"],
+  "include": ["src", "__tests__"],
   "compilerOptions": {
     "outDir": "build"
   }

diff --git a/turbo.json b/turbo.json
@@ -8,9 +8,6 @@
     "app#watch": {
       "dependsOn": ["^build"]
     },
-    "typecheck": {
-      "dependsOn": ["^typecheck"]
-    },
     "lint:ci": {},
     "lint": {},
     "clean": {