Skip to content
This repository has been archived by the owner on Jul 16, 2019. It is now read-only.

Changes to creating container deployment for service fabric. #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

askew
Copy link

@askew askew commented Apr 27, 2018

No description provided.

@lawrencegripper lawrencegripper added the size/medium medium tasks label May 1, 2018
@lawrencegripper
Copy link
Collaborator

Thanks for the work on this one @askew - Do we need to wait for the Traefik changes, to pick up the certs from environment vars, before we merge this?

@askew
Copy link
Author

askew commented May 1, 2018

The SF Træfik provider changes will be needed for this PR to be fully effective, but only for secure clusters. The certificate injection might be dependent on a fix to be released in SF 6.2 to prevent the certificate file from becoming corrupted.

@askew
Copy link
Author

askew commented May 4, 2018

To get the certificate in a Windows Container well need to have the following issue fixed. The fix is due in SF 6.2. microsoft/service-fabric-issues#448

@lawrencegripper
Copy link
Collaborator

Thanks for the update, I've marked this one as blocked for now while we wait on 6.2 release and the edits to Traefik SF Provider to read in the certs. Sound like a good plan? If you need any help on those bits let me know.

Thanks again for your hard work on this one - have a good weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants