Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send filename to xray on sbom-enrich api #291

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Jan 21, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:


Description:
sbom-enrich command should also send the file_name being enriched to xray in order to support a recent feature of GraphScan which requires Paths.

@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 21, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 21, 2025
@barv-jfrog barv-jfrog changed the title send filename to xray in sbom-enrich Send filename to xray on sbom-enrich api Jan 21, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 21, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 21, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description to the PR, checkout my comments

commands/enrich/enrich.go Outdated Show resolved Hide resolved
commands/enrich/enrich.go Outdated Show resolved Hide resolved
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jan 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 26, 2025
@attiasas attiasas self-requested a review January 26, 2025 11:32
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/enrich/enrichgraph 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich/enrich.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/enrich/enrichgraph/enrichgraph.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@attiasas attiasas merged commit d33f3e4 into jfrog:dev Jan 27, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants