This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Fix rounding and to precision #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoshydra
force-pushed
the
fix-rounding-and-to-precision
branch
from
888f3a9 to
c11c4b1
Compare
amoshydra
force-pushed
the
fix-rounding-and-to-precision
branch
from
c11c4b1 to
8a94e48
Compare
|
I have added more tests for both The tests can be reviewed first.
I will try to look into how the issue could be fixed in the next few days |
|
Could you please move this to jessealama/proposal-decimal-polyfill? This repo was supposed to be sunset in favor of proposal-decimal-polyfill. |
This was referenced Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in-progress draft for fixing
roundandtoPrecisionin v22.Todo:
toPrecisionroundprecisionroundSummary
pending
Related to
#116, jessealama/proposal-decimal-polyfill#15
How is this tested?
See updated tests for
roundandtoPrecision