Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JESI-2566 #5

Merged
merged 47 commits into from
Jan 21, 2019
Merged

JESI-2566 #5

merged 47 commits into from
Jan 21, 2019

Conversation

AndreTheHunter
Copy link

@AndreTheHunter AndreTheHunter commented Jan 15, 2019 •
edited
Loading

JESI-2566
And fixes metabase#3

  • Fix commit history by squashing
  • Create PR back into metabase/toucan

@AndreTheHunter AndreTheHunter changed the title Added IModel/primary-key JESI-2566 Jan 15, 2019
AndreTheHunter and others added 5 commits January 15, 2019 16:34
@AndreTheHunter
Made get-inserted-id public
3743579
@AndreTheHunter
Squashed commit of the following:
aa0d7e0 
commit 92a218d
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:41:52 2019 +1000

    update deploy-repositries

commit c711bc5
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:38:13 2019 +1000

    remove extra quotes

commit 2d45a0d
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:37:09 2019 +1000

    show output

commit 04a6d7c
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:14:09 2019 +1000

    WIP

commit c1499c7
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:10:33 2019 +1000

    added context

commit 33ade89
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:06:41 2019 +1000

    WIP

commit 7f082c7
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:04:41 2019 +1000

    WIP

commit 2311454
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 16:01:44 2019 +1000

    WIP

commit 0bb684a
Author: ElizabethForest <[email protected]>
Date:   Tue Jan 15 15:58:23 2019 +1000

    remove extra stringness
@ElizabethForest
exists? resolves model first
d292841
@ElizabethForest
fix selects
76a57ca
@ElizabethForest
fix braces
7481a0c
@AndreTheHunter AndreTheHunter requested a review from axrs January 17, 2019 02:58
@AndreTheHunter AndreTheHunter changed the base branch from master to models-primary-key January 17, 2019 05:53
@axrs axrs assigned AndreTheHunter and unassigned axrs Jan 17, 2019
axrs
axrs approved these changes Jan 21, 2019
View reviewed changes
Copy link

@axrs axrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@axrs axrs merged commit a15a75c into models-primary-key Jan 21, 2019
@axrs axrs deleted the JESI-2566 branch January 21, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axrs axrs axrs approved these changes

Assignees

@axrs axrs

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreTheHunter @axrs @ElizabethForest