Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversion push code needs to deal with recombinants #86

Open
jeromekelleher opened this issue Feb 6, 2023 · 2 comments
Open

Reversion push code needs to deal with recombinants #86

jeromekelleher opened this issue Feb 6, 2023 · 2 comments

Comments

@jeromekelleher
Copy link
Owner

One of the largest artefactual recombinants in the alpha version of the sc2ts trees (node 601947 in upgma-full-md-30-mm-3-2021-06-30-il.ts.tsz) is the direct result (seemingly) of reversion pushing not dealing correctly with recombinants.

@jeromekelleher
Copy link
Owner Author

In principle there's no problem with the current approach being applied to nodes which have two or more parents, it's just a little more involved and I skipped it in the initial version.

@jeromekelleher
Copy link
Owner Author

recomb-with-reversions

This looks like the same issue here (4 mutations, all immediate reversions near a recomb node)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant