Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment in additionalAuthenticationChecks to clarify why our no-op implementation is ok #10140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Jan 9, 2025

While investigating a security issue a few months back, I noticed that our implementation of AbstractUserDetailsAuthenticationProvider.additionalAuthenticationChecks did not use the approach recommended in the superclass method's Javadoc, which was a bit concerning after looking at some of the branches in this code. After some investigation it seems fine, but I think it is worth noting why it is fine in case someone copies this code when creating a new security realm and they want to use Spring Security's user caching system.

Testing done

This PR only updates a comment.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@dwnusbaum dwnusbaum added the skip-changelog Should not be shown in the changelog label Jan 9, 2025
@dwnusbaum dwnusbaum requested a review from a team January 9, 2025 21:42
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants