Bad attempt to compute absolute value of signed 32-bit hashcode in au…

….com.centrumsystems.hudson.plugin.buildpipeline.ProjectForm.getId()
jenkinsci · Nov 6, 2024 · 8fedd28 · 8fedd28
1 parent dbbcc7d
commit 8fedd28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
@@ -129,11 +129,11 @@ public List<Integer> getDependencyIds() {
      */
     @JavaScriptMethod
     public String asJSON() {
-        return BuildJSONBuilder.asJSON(context, pipelineBuild, getId(), getProjectId(), getDependencyIds(), getParameterList());
+        return BuildJSONBuilder.asJSON(context, pipelineBuild, id, projectId, getDependencyIds(), getParameterList());
     }
 
     public int getId() {
-        return Math.abs(id);
+        return id;
     }
 
     /**
@@ -171,7 +171,7 @@ public ArrayList<String> getParameterList() {
     }
 
     public Integer getProjectId() {
-        return Math.abs(projectId);
+        return projectId;
     }
 
     public AbstractBuild<?, ?> getCurrentBuild() {

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
@@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
     }
 
     public int getId() {
-        return Math.abs(name.hashCode());
+        return name.hashCode();
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -240,7 +240,7 @@ public boolean equals(final Object obj) { @@
         }
         public int getId() {
-            return Math.abs(name.hashCode());
+            return name.hashCode();
         }
         /**
@@ Expand Down @@