-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 4941 test refactoring divider element #5241
Merged
igor-vlasiuk
merged 14 commits into
angular_rework_development
from
4941-Test-refactoring-Divider-element
Dec 18, 2023
Merged
[WIP] 4941 test refactoring divider element #5241
igor-vlasiuk
merged 14 commits into
angular_rework_development
from
4941-Test-refactoring-Divider-element
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnatashap
reviewed
Dec 2, 2023
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerSeparatorAssert.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Dec 6, 2023
jdi-light-angular-tests/src/main/java/io/github/com/pages/DividerPage.java
Outdated
Show resolved
Hide resolved
...t-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/DividerTests.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerSeparatorAssert.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerSeparatorAssert.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerSeparatorAssert.java
Outdated
Show resolved
Hide resolved
jdi-light-angular-tests/src/main/java/io/github/com/pages/DividerPage.java
Outdated
Show resolved
Hide resolved
...light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/DividerSeparator.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправления текстов пропали. Странно писать, что Vertical divider is not vertical, мы не знаем какой у нас разделитель
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerAssert.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerAssert.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/DividerAssert.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Dec 9, 2023
...t-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/DividerTests.java
Show resolved
Hide resolved
pnatashap
approved these changes
Dec 11, 2023
MayaElf
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4941