feat(): add header support for proxy auth

[sandy2008]

feat(): add header support for proxy auth

[sandy2008]

@jcmturner Can you take a look at this PR? 🥹

[huaraz]

feat(): add header support for proxy auth

I would be interested to test this. How can get access t to this change ?
e.g. add
import "github.com/jcmturner/gokrb5/v8/client" ?

[sandy2008]

feat(): add header support for proxy auth

I would be interested to test this. How can get access t to this change ? e.g. add import "github.com/jcmturner/gokrb5/v8/client" ?

@huaraz Thank you for your interest in testing the changes!

To get access to this change, you can point your Go module to my fork with the master branch. Here are the steps to do this:

1. Edit your go.mod file to replace the original module with my fork:

replace github.com/jcmturner/gokrb5/v8 => github.com/sandy2008/gokrb5/v8 master

2. Run go get to update your dependencies:

go get github.com/jcmturner/gokrb5/v8

3. You can then import the package as usual:

import "github.com/jcmturner/gokrb5/v8/client"

If you encounter any issues or have further questions, please let me know!

[huaraz]

Hi Sandy,

I looked a bit more at the code and I tried what you do in setSPNEGOHeaderCommon earlier myself and it does not work for https i.e. CONNECT method. I had to do the following:

    transport := &http.Transport{
            Proxy:              http.ProxyURL(proxyURL),
            GetProxyConnectHeader: func(ctx context.Context, proxyURL *url.URL, target string) (http.Header, error) {
                                        headers := http.Header{}
                                        headers.Add("Proxy-Authorization", negoAuth)
                                        return headers, nil
                                   },
    }

or use
ProxyConnectHeader: http.Header{"Proxy-Authorization": []string{negoAuth}},

FYI I have not tried your code yet.

Markus

[sandy2008]

Hi Sandy,

I looked a bit more at the code and I tried what you do in setSPNEGOHeaderCommon earlier myself and it does not work for https i.e. CONNECT method. I had to do the following:

    transport := &http.Transport{
            Proxy:              http.ProxyURL(proxyURL),
            GetProxyConnectHeader: func(ctx context.Context, proxyURL *url.URL, target string) (http.Header, error) {
                                        headers := http.Header{}
                                        headers.Add("Proxy-Authorization", negoAuth)
                                        return headers, nil
                                   },
    }

or use ProxyConnectHeader: http.Header{"Proxy-Authorization": []string{negoAuth}},

FYI I have not tried your code yet.

Markus

Hi, let me add the support for this as well :)