[better_errors] Ensure debug_info.arg_names is never None. #25992
+175
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
debug_info_arg_names
branch
from
df6116e to
870da21
Compare
gnecula
force-pushed
the
debug_info_arg_names
branch
8 times, most recently
from
9b41326 to
6aa552b
Compare
gnecula
force-pushed
the
debug_info_arg_names
branch
3 times, most recently
from
96b2395 to
6c5a6bc
Compare
Most places in the code assumed this already, but often that usage is error reporting code, which is not yet well tested. When we cannot get the `inspect.Signature` or when the args and kwargs do not match the signature, we generate the flattened argument names as: `args[0]`, `args[1]`, `kwargs['foo']`, ... Previously, in these cases we returned `arg_names` is None, and then the whole debug_info ended up being `None`, throwing away even available information. We also add support for `api_util.fun_sourceinfo` even for cases when the `fun.__code__` is not available. In those cases we used to say that `fun_sourceinfo` is `None`. Now, we use the string representation of `fun` to get the name of built-in functions, or we use "<unknown>".
gnecula
force-pushed
the
debug_info_arg_names
branch
from
6c5a6bc to
3f73f7b
Compare
dfm
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most places in the code assumed this already, but often that usage is error reporting code, which is not yet well tested.
When we cannot get the
inspect.Signature, or when theargsandkwargsdo not match the signature, we generate the flattened argument names as:args[0],args[1],kwargs['foo'], ... Previously, in these cases we returnedarg_namesis None, and then the whole debug_info ended up beingNone, throwing away even available information.We also add support for
api_util.fun_sourceinfoeven for cases when thefun.__code__is not available. Inthose cases we used to say that
fun_sourceinfoisNone. Now, we use the string representation offunto get the name of built-in functions, or we use "".