Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm scripts to match new build.py usage #25096

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update ROCm scripts to match new build.py usage #25096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions build/rocm/dev_build_rocm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,14 @@ def build_jax_xla(xla_path, rocm_version, rocm_target, use_clang, clang_path):
build_command = [
"python3",
"./build/build.py",
"--enable_rocm",
"--build_gpu_plugin",
"--gpu_plugin_rocm_version=60",
"build"
f"--use_clang={str(use_clang).lower()}",
"--wheels=jaxlib,jax-rocm-plugin,jax-rocm-pjrt"
"--rocm_path=%/opt/rocm-{rocm_version}/",
"--rocm_version=60",
f"--rocm_amdgpu_targets={rocm_target}",
f"--rocm_path=/opt/rocm-{rocm_version}/",
bazel_options,
"--verbose"
]

if clang_option:
Expand Down
7 changes: 4 additions & 3 deletions build/rocm/tools/build_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,12 @@ def build_jaxlib_wheel(
cmd = [
"python",
"build/build.py",
"--enable_rocm",
"--build_gpu_plugin",
"--gpu_plugin_rocm_version=60",
"build"
"--wheels=jaxlib,jax-rocm-plugin,jax-rocm-pjrt"
"--rocm_path=%s" % rocm_path,
"--rocm_version=60",
"--use_clang=%s" % use_clang,
"--verbose"
]

# Add clang path if clang is used.
Expand Down
Loading