-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency lift + appropriate code changes and adjusted README since … #45
Conversation
…stringArrayEncoding is expected to be a string array
@mppperez Thanks for your work! |
hi @nicholaslee119, could u provide a sample? I've just compared the this discussion may be better in an own issue here referencing this PR. best regards |
Perfect, this branch fixes the problems. The obfuscating is good but the application crashes on startup :
|
What is the progress on this PR? I am also encountering this issue when bundling my app. @mppperez @nicholaslee119 |
Unfortunately I do not have permission to merge the PR or make a release. You would need to apply the changes manually for now if you want to continue to use this lib. I guess this will be my last PR for this as well (had another one for fixes with RN > 0.59) since it seems like this project won't be ressurected anymore although there are still many ppl left using it. Any suggestion for a good alternative are welcome ... probably ending up using javascript-obfuscator directly as already mentioned in #15 |
@sanex3339 could this be merged? I've been running it in my app using a private fork for months with no issues |
I can merge it but i can't release it |
Who can release it? @ds300 can you? |
Fix for issue #43