fix: Issue 227 - Named Creatures of same type append 1 #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix Issue 227 where in the Encounter Tracker, named or not named Creatures had a counter next to their name based on their underlying type (Gobelin, Hobgobelin, etc...) instead of their actual name (John Doe, Foo, Bar...).
Changes Proposed
Related Issues
Fixes Issue 227 Named Creatures of same type append 1
Fixes Issue 283 Named Creatures have a "1" after their names in right panel
Checklist
Screenshots (if applicable)
With the changes, here is the tracker : As you can see, the first of each distinct name has no numbers, then we count 1,2,3...
Additional Notes
My main goal was to discover your code by trying to fix something easy.
My main goal after that is to implement the rules specific to the TTRPG TheOneRing to track combat.
That's my first contribution to an OSS and also my first PR in GitHub (although I'm working as an experienced SE, but mainly in C#), so do tell me if I did anything wrong.