Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): prioritize pf2e icons over system font #420

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

dylbrown
Copy link
Contributor

@dylbrown dylbrown commented Jun 4, 2024

Pull Request Description

When using the plugin on iOS with Pathfinder 2e, the action icons in the bestiary community content, which are ⬽ or similar in the descriptions, don't render using the "Pathfinder" icon font as they do on Windows. This is because the system-ui font takes precedence, and on iOS that font includes these icons.

Changes Proposed

  • Place "Pathfinder" before system-ui in --statblock-content-font and --statblock-heading-font for pf2e.css
  • Change the "Pathfinder" @font-face specification so it only includes the icons, the whitespace was breaking things on iOS

Related Issues

Obsidian-TTRPG-Community/Fantasy-Statblocks-CSS-Development#10

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

Before After
Before After

Additional Notes

N/A

@valentine195 valentine195 merged commit 4de2457 into javalent:main Aug 9, 2024
@scooper4711
Copy link
Contributor

I've been testing against main, which includes this fix, on MacOS. On MacOS, it appears to break displaying the ability scores, as the Pathfinder font doesn't include the number zero.

See #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants