Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject uppercase in admonition type #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

almarouk
Copy link

Pull Request Description

Uppercase letters shouldn't be allowed in admonition type. Otherwise, it will cause failure when checking if the callout/admonition is a custom one; for example in the following:

const admonition = this.plugin.admonitions[type];

Changes Proposed

  • Add an additional validation case that tests for uppercase.

Related Issues

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Reject uppercase in admonition type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant