use rot command where possible #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janko fwiw we've currently got a bunch of environments where we have trouble installing vips (though we use it in prod) and so we have to have conditional code that uses the built in rotate in image_magick envs and crafts a custom rot(90|180|270) command when we have vips. Would be great to be able to remove those workarounds. |
|
I appreciate the PR, and sorry for the delay 😅 Looks good, I will try to make a release soon 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The similarity command leaves a line on the side of 90/180/270 rotations. This PR uses the rot command where possible.
resolves #104